Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-6824: changed help text for spacer paragraph #700

Closed
wants to merge 1 commit into from

Conversation

imonroe
Copy link
Contributor

@imonroe imonroe commented Aug 8, 2023

READY FOR REVIEW

Summary

  • Update the help text in the Spacer paragraph

Review By (Date)

  • code freeze

Criticality

  • 2

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Review in conjunction with: D8CORE-6824: Spacer paragraph - changed label of default value stanford_profile_helper#265

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? yes

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@pookmish
Copy link
Contributor

@imonroe this can be close now right?

@imonroe
Copy link
Contributor Author

imonroe commented Sep 18, 2023

Yep. Closing now.

@imonroe imonroe closed this Sep 18, 2023
@imonroe imonroe deleted the D8CORE-6824 branch September 18, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants